Skip to content

[WIP] Try meta's executorch#4134

Draft
lanluo-nvidia wants to merge 7 commits intomainfrom
lluo/executorch_lan_312
Draft

[WIP] Try meta's executorch#4134
lanluo-nvidia wants to merge 7 commits intomainfrom
lluo/executorch_lan_312

Conversation

@lanluo-nvidia
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this Mar 18, 2026
@meta-cla meta-cla bot added the cla signed label Mar 18, 2026
@lanluo-nvidia lanluo-nvidia added WIP Work is in progress, pull request should not be merged yet and removed cla signed labels Mar 18, 2026
@github-actions github-actions bot added component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 18, 2026
@github-actions github-actions bot requested a review from zewenli98 March 18, 2026 18:22
@meta-cla meta-cla bot added the cla signed label Mar 18, 2026
@github-actions github-actions bot added the component: build system Issues re: Build system label Mar 24, 2026
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py	2026-03-24 22:53:45.461148+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py	2026-03-24 22:54:02.896694+00:00
@@ -1159,10 +1159,11 @@
            "ExecuTorch is not installed. Please install it to use output_format='executorch'. "
            "See https://pytorch.org/executorch/stable/getting-started-setup.html"
        )
    import torch_tensorrt.dynamo.runtime.meta_ops.register_meta_ops  # noqa: F401
    from torch_tensorrt.executorch import TensorRTPartitioner
+
    extra_partitioners = kwargs.get("partitioners", [])
    partitioners = [TensorRTPartitioner()] + extra_partitioners

    # DO I NEED THIS?
    # Replace execute_engine with no_op_placeholder before edge lowering so that
--- /home/runner/work/TensorRT/TensorRT/setup.py	2026-03-24 22:53:45.475147+00:00
+++ /home/runner/work/TensorRT/TensorRT/setup.py	2026-03-24 22:54:05.047188+00:00
@@ -34,10 +34,11 @@

LEGACY_BASE_VERSION_SUFFIX_PATTERN = re.compile("a0$")
# CI_PIPELINE_ID is the environment variable set by DLFW ci build
IS_DLFW_CI = os.environ.get("CI_PIPELINE_ID") is not None
IS_DLFW_CI = True
+

def get_root_dir() -> Path:
    return Path(__file__).parent.absolute()

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/setup.py	2026-03-24 23:33:42.687514+00:00
+++ /home/runner/work/TensorRT/TensorRT/setup.py	2026-03-24 23:34:03.197466+00:00
@@ -34,10 +34,11 @@

LEGACY_BASE_VERSION_SUFFIX_PATTERN = re.compile("a0$")
# CI_PIPELINE_ID is the environment variable set by DLFW ci build
IS_DLFW_CI = os.environ.get("CI_PIPELINE_ID") is not None
IS_DLFW_CI = True
+

def get_root_dir() -> Path:
    return Path(__file__).parent.absolute()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime WIP Work is in progress, pull request should not be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant